Skip to content

install: Rename composefs-native -> composefs-backend#119

Merged
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:drop-composefs-flag
Nov 3, 2025
Merged

install: Rename composefs-native -> composefs-backend#119
cgwalters merged 1 commit into
bootc-dev:mainfrom
cgwalters:drop-composefs-flag

Conversation

@cgwalters
Copy link
Copy Markdown
Collaborator

This is how the option is called in latest bootc.

Closes: #117

This is how the option is called in latest bootc.

Closes: bootc-dev#117

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the composefs-native option to composefs-backend to align with recent changes in bootc. The changes are mostly correct, but I've found a few places where the old name is still used in comments. More importantly, it seems the argument passed to the bootc command was not updated, which could lead to incorrect behavior. I've left specific suggestions to address these points.

Comment thread crates/kit/src/install_options.rs
Comment thread crates/kit/src/cache_metadata.rs
Comment thread crates/kit/src/cache_metadata.rs
Comment thread crates/kit/src/install_options.rs
@cgwalters cgwalters force-pushed the drop-composefs-flag branch from 0cd8343 to a260687 Compare November 3, 2025 12:19
@cgwalters cgwalters enabled auto-merge (rebase) November 3, 2025 13:13
@cgwalters cgwalters merged commit e170ed4 into bootc-dev:main Nov 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: Unsupported --composefs-native flag

3 participants